[Improve] Make guided agent interactions reliable - #2475
Closed
roomote-roomote[bot] wants to merge 133 commits into
Closed
[Improve] Make guided agent interactions reliable#2475roomote-roomote[bot] wants to merge 133 commits into
roomote-roomote[bot] wants to merge 133 commits into
Conversation
Promote v0.0.2 to production
Promote v0.0.3 to production
Promote v0.0.4 to production
Promote v0.1.0 to production
Promote v0.1.1 to production
Promote v0.2.0 to production
Promote v0.3.0 to production
Promote v0.3.1 to production
Promote v0.4.0 to production
Promote v0.4.1 to production
SlackSetupExperience's intro screen owns the step action buttons, and it is skipped when the Slack config is already saved (savedSatisfied). But StepAuthEnvVars's providerOwnsActions check was missing the matching !savedSatisfied clause, so revisiting the auth step with saved Slack credentials rendered the value form with no action button at all, stranding the user on the page. Align providerOwnsActions with the intro guard and add a regression test for the saved-Slack revisit path. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Hotfix-only cut from main with the #299 Slack setup Continue fix.
[Chore] Release Roomote 0.4.2 hotfix for saved Slack continue
Drop the reverted analytics Model group-by line and document notification destination and homepage dump-flash fixes now included on release/v0.5.0.
Promote v0.5.0 to production
Promote v0.6.0 to production
Promote v0.7.0 to production
Promote v0.7.1 to production
Promote v0.8.0 to production
Promote v0.8.1 to production
Promote v0.9.0 to production
….4.1 [Fix] Release Roomote 1.4.1 for failing GPT-5.x integration lookups
Promote v1.5.0 to production
Promote v1.5.1 to production
Promote v1.6.0 to production
Contributor
|
No new code issues found; the final setup-card continuation finding is addressed and resolved. See task
Reviewed d8ab2a6 |
Contributor
Author
|
Superseded by #2473, which uses the same latest source branch and contains all review fixes against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
request_user_inputtool rows only when a card exists, keep failed tool calls visible, and leave the composer available beside optional questions.This standalone draft contains and supersedes the relevant implementation from PR #2402. It does not depend on #2402 landing; #2402 remains open and unchanged.
The source branch itself is based directly on
main. The PR base still needs to be retargeted tomain: the provider-neutral update operation created duplicate draft #2473 instead of changing #2470, and the current task API exposes no retarget or close operation. Do not merge either draft until #2470 is retargeted and #2473 is closed.Why this change was made
Setup Sessions could require several attempts because tool plumbing appeared before cards, human choices disappeared or showed internal values, asynchronous setup events produced incoherent ordering, and a saved answer could be stranded before model continuation. Connection state and chat interaction guarantees also differed across surfaces.
Impact
Guided interactions now read as one coherent conversation and remain correct across reloads, retries, concurrent submissions, and supported chat adapters. The prompt keeps a deliberately designed setup progression while users can skip or reorder optional steps and the backend enforces reliable conversation-wide behavior.
Validation and local testing
Passed against the standalone
mainancestry:pnpm check-types:fastpnpm lint:fastpnpm knip(only the existing Mint configuration hint)Branch ancestry is exactly four commits ahead of
origin/main: the two setup-discovery commits, the guided-interactions implementation, and the review-fix commit. Its merge base equals the currentorigin/main; unrelated post-releasedevelopcommits are excluded.The preview browser was unauthenticated and further login/browser verification was explicitly canceled. No authenticated browser result, screenshot, ordinary-session live smoke, or external OAuth completion is claimed.
Local verification:
git fetch origingit switch feature/guided-interactions-2hkp457mhpgozmise install && pnpm installpnpm dev.